Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable20] better cleanup of filecache when deleting an external storage #27207

Closed
wants to merge 2 commits into from
Closed

[stable20] better cleanup of filecache when deleting an external storage #27207

wants to merge 2 commits into from

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #26936

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.11 milestone May 28, 2021
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label May 28, 2021
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
6 tasks
@blizzz
Copy link
Member

blizzz commented Jun 23, 2021

CI is unhappy

@blizzz blizzz mentioned this pull request Jul 1, 2021
Merged
4 tasks
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 1, 2021
@github-actions github-actions bot force-pushed the backport/26936/stable20 branch from d0a5cf3 to 37c428f Compare July 15, 2021 20:12
@skjnldsv skjnldsv mentioned this pull request Jul 26, 2021
Merged
11 tasks
@skjnldsv
Copy link
Member

/rebase

@github-actions github-actions bot force-pushed the backport/26936/stable20 branch from 37c428f to 7344770 Compare July 28, 2021 05:37
@skjnldsv skjnldsv closed this Jul 28, 2021
@skjnldsv skjnldsv reopened this Jul 28, 2021
@skjnldsv skjnldsv mentioned this pull request Aug 3, 2021
Merged
9 tasks
@blizzz blizzz mentioned this pull request Sep 23, 2021
Merged
8 tasks
@MichaIng MichaIng force-pushed the backport/26936/stable20 branch from 7344770 to 7311ce9 Compare September 24, 2021 12:00
@MichaIng
Copy link
Member

Strange, static code analysis diff is identical to here: https://github.com/nextcloud/server/pull/26630/checks?check_run_id=3699661869

@MichaIng MichaIng force-pushed the backport/26936/stable20 branch from 7311ce9 to 90ee38a Compare October 12, 2021 11:34
@skjnldsv
Copy link
Member

/rebase

@blizzz
Copy link
Member

blizzz commented Oct 20, 2021

CI unhappy

@MichaIng
Copy link
Member

executeQuery was added with NC22: 76a6328

@blizzz blizzz mentioned this pull request Nov 3, 2021
Merged
15 tasks
MichaIng
MichaIng requested changes Nov 18, 2021
View reviewed changes
lib/private/Files/Cache/Storage.php Outdated Show resolved Hide resolved
lib/private/Files/Cache/Storage.php Outdated Show resolved Hide resolved
@icewind1991 @MichaIng
better cleanup of filecache when deleting an external storage
b83c947 
this way it can delete the cache entries even with per-user credentials

Signed-off-by: Robin Appelman <robin@icewind.nl>
@MichaIng MichaIng force-pushed the backport/26936/stable20 branch from 74261d2 to b83c947 Compare November 18, 2021 13:34
MichaIng
MichaIng approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@MichaIng MichaIng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining Psalm errors are unrelated and should be solved with: #29556

@MichaIng MichaIng added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels Nov 18, 2021
MichaIng
MichaIng requested changes Nov 18, 2021
View reviewed changes
Copy link
Member

@MichaIng MichaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, more changes required...

@MichaIng
Use pre-v22 query commands
ab36256 
Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng MichaIng force-pushed the backport/26936/stable20 branch from cc52cdf to ab36256 Compare November 18, 2021 14:11
@MichaIng
Copy link
Member

MichaIng commented Nov 18, 2021 •
edited
Loading

lib/private/Files/Cache/Storage.php#L244
Argument 2 of OCP\DB\QueryBuilder\IExpressionBuilder::in expects array<array-key, mixed>|string, OCP\DB\QueryBuilder\IParameter provided with a __toString method

This is related, not present on NC21 backport anymore, but currently not sure how to solve it. Probably this included the fix?

@rakekniven rakekniven removed this from the Nextcloud 20.0.14 milestone Nov 19, 2021
@MichaIng
Copy link
Member

Marking as closed as NC20 is EOL. If wanted to customers, it can be reopened at any time.

@MichaIng MichaIng closed this Nov 19, 2021
@MichaIng MichaIng deleted the backport/26936/stable20 branch November 19, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaIng MichaIng MichaIng requested changes

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@julien-nc julien-nc Awaiting requested review from julien-nc

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees
No one assigned
Labels
2. developing Work in progress feature: external storage feature: filesystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blizzz @skjnldsv @MichaIng @MorrisJobke @rakekniven @icewind1991